Skip to content

The embeded help link in versions page is broken #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gregmuellegger opened this issue Jun 18, 2015 · 2 comments · Fixed by #1383
Closed

The embeded help link in versions page is broken #1353

gregmuellegger opened this issue Jun 18, 2015 · 2 comments · Fixed by #1383

Comments

@gregmuellegger
Copy link
Contributor

Nothing happens when you click on the (Help) link:
screen

@gregmuellegger
Copy link
Contributor Author

The markup for the link looks like this:

<div id="help_container">
  <a href="#" class="quiet readthedocs-help-embed">(Help)</a>
</div>

So I assumed that there is some reference to help_container or readthedocs-help-embed in the Javascript, but there isn't. So it seems that this help has no chance to work.

Is there something missing that was once in place? I found only this reference: a36a1dc#diff-77fa4d857406100554a8766dc8f0c871R28 but it seems that this code has been deleted at some point.

@ericholscher
Copy link
Member

This should be removed for now. We need to improve the performance of our Embed API before it makes sense to re-enable this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants