Skip to content

File tree diff: allow ignoring files #11694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stsewd opened this issue Oct 17, 2024 · 1 comment · Fixed by #11977
Closed

File tree diff: allow ignoring files #11694

stsewd opened this issue Oct 17, 2024 · 1 comment · Fixed by #11977
Assignees
Labels
Feature New feature

Comments

@stsewd
Copy link
Member

stsewd commented Oct 17, 2024

What's the problem this feature will solve?

With the new FTD feature, there may be some files that always get changes, or that aren't really relevant for the diff.

Describe the solution you'd like

Users should have an option to ignore these files from being considered in the diff, similar to what we have in our search config https://docs.readthedocs.io/en/stable/config-file/v2.html#search-ignore.

Alternative solutions

Just deal with the files, maybe just have a nice filtering UI.

Additional context

#11646

@stsewd stsewd added Feature New feature Needed: design decision A core team decision is required labels Oct 17, 2024
@humitos
Copy link
Member

humitos commented Jan 29, 2025

maybe just have a nice filtering UI

This is an interesting thing to consider. We can always calculate the diff of all these files, but not show them in the UI under the list of files changed. That way, if this list of ignored files change, we don't need to re-build all these versions.

@humitos humitos self-assigned this Feb 5, 2025
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Feb 5, 2025
@humitos humitos moved this from Planned to Needs review in 📍Roadmap Feb 5, 2025
@humitos humitos removed the Needed: design decision A core team decision is required label Feb 5, 2025
humitos added a commit that referenced this issue Feb 5, 2025
Add a field to allow users to tell us what files should be ignored when
comparing versions. This is going to be used by the front-end to don't expose
these files in the list of added/modified/deleted files.

Closes #11694
@humitos humitos moved this from Needs review to In progress in 📍Roadmap Feb 5, 2025
@humitos humitos moved this from In progress to Needs review in 📍Roadmap Feb 10, 2025
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Feb 10, 2025
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants