Skip to content

Notifications: always show notifications on build details' page #11146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
humitos opened this issue Feb 24, 2024 · 1 comment · Fixed by #11153
Closed

Notifications: always show notifications on build details' page #11146

humitos opened this issue Feb 24, 2024 · 1 comment · Fixed by #11153
Assignees
@humitos
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@humitos
Copy link
Member

humitos commented Feb 24, 2024

It seems that in #11117 we introduced a bug that it only shows the notifications for the build to users that have permissions over that project in particular --which is wrong. Since the project is public, it should show the notifications to all the users with access to the build detail's page.
@humitos humitos added Bug A bug Accepted Accepted issue on our roadmap labels Feb 24, 2024
@humitos humitos mentioned this issue Feb 24, 2024
Closed
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Feb 24, 2024
@humitos humitos mentioned this issue Feb 24, 2024
Closed
@taylorhummon
Copy link
Contributor

I've recreated the issue with a minimal install at:
https://github.com/taylorhummon/silently-failing-build
See:
https://readthedocs.org/projects/silently-failing-build/builds/23550653/

humitos added a commit that referenced this issue Feb 26, 2024
@humitos
Build: bugfix to show build notifications
92afef7 
The context was updated in the wrong place.

Closes #11146
@humitos humitos self-assigned this Feb 26, 2024
@humitos humitos moved this from Planned to Needs review in 📍Roadmap Feb 26, 2024
@humitos humitos mentioned this issue Feb 26, 2024
Merged
humitos added a commit that referenced this issue Feb 27, 2024
@humitos
Build: bugfix to show build notifications (#11153)
ac518c7 
The context was updated in the wrong place.

Closes #11146
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humitos humitos

Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build: bugfix to show build notifications readthedocs/readthedocs.org
2 participants
@humitos @taylorhummon