Skip to content

Requirements: upgrade django-structlog to its latest version #10933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
humitos opened this issue Nov 28, 2023 · 4 comments
Open

Requirements: upgrade django-structlog to its latest version #10933

humitos opened this issue Nov 28, 2023 · 4 comments
Assignees

Comments

@humitos
Copy link
Member

humitos commented Nov 28, 2023

We are currently using 2.2.0 but the latest release is 6.x. We pause upgrading it because it required some extra work by that time. Maybe, due to #10932 the time for updating it has arrived.

# Upgrading to 3.x requires some extra work
# https://django-structlog.readthedocs.io/en/latest/upgrade_guide.html#upgrading-to-3-0
# NOTE: that django-structlog is in version 6.x now,
# so we should probably consider migrating to avoid incompatibility issues.
django-structlog==2.2.0
# Pining due to a Sentry error we started getting
# https://read-the-docs.sentry.io/issues/4678167578/events/2d9d348729874d67b120b153908ca54c/
django-ipware<6.0.0

@humitos
Copy link
Member Author

humitos commented Jan 11, 2024

Maybe related to:

@agjohnson
Copy link
Contributor

I think you're working on this right now @humitos so bumped up on the roadmap. Close this if you want though.

@humitos
Copy link
Member Author

humitos commented Feb 29, 2024

Yeah, I did a quick try upgrading this to check if the TemplateSyntaxError was faster, but it was the same.

So, there is no rush on moving forward with this now. We can wait if we want.

@ericholscher
Copy link
Member

This will likely be required when we upgrade Python or Django.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planned
Development

No branches or pull requests

3 participants