Skip to content

Builds: avoid breaking builds when adding a new field to our APIs #10257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stsewd opened this issue Apr 18, 2023 · 1 comment · Fixed by #10295
Closed

Builds: avoid breaking builds when adding a new field to our APIs #10257

stsewd opened this issue Apr 18, 2023 · 1 comment · Fixed by #10295
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Apr 18, 2023

When adding a new field to our API, builds will immediately receive that new field, but our builders don't know about that new field yet, so creating an APIVersion or APIProject instance will fail

return APIProject(**project_data)

We could inspect the available fields from the model to create the object only with those fields, and maybe log the fields that aren't part of the model.

ref #10256

@stsewd stsewd added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Apr 18, 2023
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Apr 18, 2023
@humitos
Copy link
Member

humitos commented Apr 19, 2023

We could inspect the available fields from the model to create the object only with those fields, and maybe log the fields that aren't part of the model.

I like this idea. It will allow us to have both builders (old and new ones) at the same time while doing a deploy 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants