Skip to content

Commit fab58c9

Browse files
committed
Add extra build pk for sentry
1 parent e94959a commit fab58c9

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

readthedocs/projects/tasks.py

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -130,22 +130,27 @@ def run(self, pk, version_pk=None, build_pk=None, record=True,
130130
self.run_build(record=record, docker=docker)
131131
failure = self.setup_env.failure or self.build_env.failure
132132
except Exception as e: # noqa
133-
log.exception('Top-level build exception has been raised')
133+
log.exception('Top-level build exception has been raised', extra={'build': build_pk})
134134
failure = str(e)
135135

136136
# **Always** report build status.
137137
# This can still fail if the API Is totally down, but should catch more failures
138138
result = {}
139+
error = 'Unknown error. Please include the build id ({}) in any bug reports.'.format(
140+
build_pk
141+
)
139142
if hasattr(self, 'build'):
140143
self.build['state'] = BUILD_STATE_FINISHED
141144
if failure:
142-
self.build['error'] = 'Unknown setup failure: {}'.format(failure)
145+
self.build['error'] = error
143146
self.build['success'] = False
144147
result = api_v2.build(build_pk).patch(self.build)
145148
else:
146-
build_updates = {'state': BUILD_STATE_FINISHED,
147-
'success': False,
148-
'error': 'Unknown setup failure: {}'.format(failure)}
149+
build_updates = {
150+
'state': BUILD_STATE_FINISHED,
151+
'success': False,
152+
'error': error,
153+
}
149154
result = api_v2.build(build_pk).patch(build_updates)
150155
return result
151156

@@ -259,7 +264,7 @@ def run_build(self, docker=False, record=True):
259264
def get_project(project_pk):
260265
"""Get project from API"""
261266
project_data = api_v2.project(project_pk).get()
262-
return APIProject(**project_data)
267+
# return APIProject(**project_data)
263268

264269
@staticmethod
265270
def get_version(project, version_pk):

0 commit comments

Comments
 (0)