Fix logging to always send everything, and filter in handlers

Author: ericholscher

readthedocs/settings/base.py

@@ -355,15 +355,14 @@ def INSTALLED_APPS(self):  # noqa
             },
         },
         'loggers': {
-            'readthedocs': {
+            '': {  # root logger
                 'handlers': ['debug', 'console'],
-                'level': 'DEBUG',
-                'propagate': True,
+                'level': 'DEBUG',  # Always send from the root, handlers can filter levels
             },
-            '': {
+            'readthedocs': {
                 'handlers': ['debug', 'console'],
                 'level': 'DEBUG',
-                'propagate': True,
+                'propagate': False,  # Don't double log at the root logger for these.
             },
         },
     }

readthedocs/settings/dev.py

@@ -56,8 +56,6 @@ def DATABASES(self):  # noqa
     def LOGGING(self):  # noqa - avoid pep8 N802
         logging = super(CommunityDevSettings, self).LOGGING
         logging['formatters']['default']['format'] = '[%(asctime)s] ' + self.LOG_FORMAT
-        # Remove double logging
-        logging['loggers']['']['handlers'] = []
         return logging