Run pdflatex three times during PDF build

We had a report in #1557 that creating the index for the PDF does not work and
that it might be related to how often we run `pdflatex` during the build.

Related #1557.

Author: gregmuellegger

readthedocs/doc_builder/backends/sphinx.py

@@ -287,6 +287,10 @@ def build(self, **kwargs):
             cmd_ret = self.build_env.run_command_class(
                 cls=LatexBuildCommand, cmd=cmd, cwd=latex_cwd, warn_only=True)
             pdf_commands.append(cmd_ret)
+        for cmd in pdflatex_cmds:
+            cmd_ret = self.build_env.run_command_class(
+                cls=LatexBuildCommand, cmd=cmd, cwd=latex_cwd, warn_only=True)
+            pdf_commands.append(cmd_ret)
         for cmd in pdflatex_cmds:
             cmd_ret = self.build_env.run_command_class(
                 cls=LatexBuildCommand, cmd=cmd, cwd=latex_cwd, warn_only=True)

readthedocs/rtd_tests/tests/test_builds.py

@@ -143,6 +143,7 @@ def test_build_pdf_latex_failures(self):
             (('', ''), 1),  # latex
             (('', ''), 0),  # makeindex
             (('', ''), 0),  # latex
+            (('', ''), 0),  # latex
         ]
         mock_obj = mock.Mock()
         mock_obj.communicate.side_effect = [output for (output, status)
@@ -153,7 +154,7 @@ def test_build_pdf_latex_failures(self):
 
         with build_env:
             built_docs = task.build_docs()
-        self.assertEqual(self.mocks.popen.call_count, 5)
+        self.assertEqual(self.mocks.popen.call_count, 6)
         self.assertTrue(build_env.failed)
 
     def test_build_pdf_latex_not_failure(self):
@@ -182,6 +183,7 @@ def test_build_pdf_latex_not_failure(self):
             (('Output written on foo.pdf', ''), 1),  # latex
             (('', ''), 0),  # makeindex
             (('', ''), 0),  # latex
+            (('', ''), 0),  # latex
         ]
         mock_obj = mock.Mock()
         mock_obj.communicate.side_effect = [output for (output, status)
@@ -192,5 +194,5 @@ def test_build_pdf_latex_not_failure(self):
 
         with build_env:
             built_docs = task.build_docs()
-        self.assertEqual(self.mocks.popen.call_count, 5)
+        self.assertEqual(self.mocks.popen.call_count, 6)
         self.assertTrue(build_env.successful)