Tests updated

Author: saadmk11

readthedocs/rtd_tests/tests/test_privacy_urls.py

@@ -8,7 +8,8 @@
 from django_dynamic_fixture import get
 from taggit.models import Tag
 
-from readthedocs.builds.models import Build, BuildCommandResult
+from readthedocs.builds.constants import EXTERNAL
+from readthedocs.builds.models import Build, BuildCommandResult, Version
 from readthedocs.core.utils.tasks import TaskNoPermission
 from readthedocs.integrations.models import HttpExchange, Integration
 from readthedocs.oauth.models import RemoteOrganization, RemoteRepository
@@ -139,7 +140,11 @@ class ProjectMixin(URLAccessMixin):
 
     def setUp(self):
         super().setUp()
+        self.external_version = get(Version, project=self.pip, type=EXTERNAL)
         self.build = get(Build, project=self.pip)
+        self.external_build = get(
+            Build, project=self.pip, version=self.external_version
+        )
         self.tag = get(Tag, slug='coolness')
         self.subproject = get(
             Project, slug='sub', language='ja',

readthedocs/rtd_tests/tests/test_views.py

@@ -316,24 +316,9 @@ def test_external_build_list_includes_external_version_builds(self):
         self.assertEqual(response.status_code, 200)
         self.assertIn(external_version_build, response.context['build_qs'])
 
-    def test_external_build_list_does_not_include_internal_version_builds(self):
-        internal_version = get(
-            Version,
-            project = self.pip,
-            active = True,
-            type = BRANCH,
-        )
-        internal_version_build = get(
-            Build,
-            project = self.pip,
-            version = internal_version
-        )
+    def test_external_build_list_returns_404_if_no_external_build_available(self):
         response = self.client.get(
             reverse('external_builds_project_list', args=[self.pip.slug]),
         )
 
-        self.assertEqual(response.status_code, 200)
-        self.assertNotIn(
-            internal_version_build,
-            response.context['build_qs']
-        )
+        self.assertEqual(response.status_code, 404)