Only show external build tab if external builds are available

Author: saadmk11

readthedocs/builds/views.py

@@ -119,9 +119,10 @@ def get_context_data(self, **kwargs):
 
 class ExternalBuildList(BuildBase, ListView):
     template_name = 'builds/external_build_list.html'
+    allow_empty = False
 
     def get_queryset(self):
-        # this is used to include only internal version
+        # this is used to include only external version
         # builds in the build list page
         self.project_slug = self.kwargs.get('project_slug', None)
         self.project = get_object_or_404(

readthedocs/projects/models.py

@@ -20,7 +20,7 @@
 from taggit.managers import TaggableManager
 
 from readthedocs.api.v2.client import api
-from readthedocs.builds.constants import LATEST, STABLE, INTERNAL
+from readthedocs.builds.constants import LATEST, STABLE, INTERNAL, EXTERNAL
 from readthedocs.core.resolver import resolve, resolve_domain
 from readthedocs.core.utils import broadcast, slugify
 from readthedocs.projects import constants
@@ -1115,6 +1115,10 @@ def environment_variables(self):
             for variable in self.environmentvariable_set.all()
         }
 
+    @property
+    def has_external_builds(self):
+        return self.builds(manager=EXTERNAL).exists()
+
 
 class APIProject(Project):
 

readthedocs/rtd_tests/tests/test_project.py

@@ -172,6 +172,13 @@ def test_get_external_builds_url(self):
             f'/projects/{self.pip.slug}/builds/pr/'
         )
 
+    def test_project_has_external_builds(self):
+        external_build = Build.objects.create(
+            project=self.pip,
+            version=self.external_version,
+        )
+        self.assertTrue(self.pip.has_external_builds)
+
 
 class TestProjectTranslations(ProjectMixin, TestCase):
 

readthedocs/templates/core/project_bar_base.html

@@ -45,7 +45,9 @@ <h1>
 
         <li class="{{ builds_active }}"><a href="{{ project.get_builds_url }}">{% trans "Builds" %}</a></li>
 
-        <li class="{{ external_builds_active }}"><a href="{{ project.get_external_builds_url }}">{% trans "External Builds" %}</a></li>
+        {% if project.has_external_builds %}
+            <li class="{{ external_builds_active }}"><a href="{{ project.get_external_builds_url }}">{% trans "External Builds" %}</a></li>
+        {% endif %}
 
         <li class="{{ versions_active }}"><a href="{% url "project_version_list" project.slug %}">{% trans "Versions" %}</a></li>