Resolve linting messages in readthedocs.search.*

Author: gregmuellegger

readthedocs/search/indexes.py

@@ -169,13 +169,13 @@ def get_mapping(self):
         """
         Returns the mapping for this _index and _type.
         """
-        raise NotImplemented
+        raise NotImplementedError()
 
-    def extract_document(self, pk, obj):
+    def extract_document(self, data):
         """
         Extracts the Elasticsearch document for this object instance.
         """
-        raise NotImplemented
+        raise NotImplementedError()
 
     def update_aliases(self, new_index, delete=True):
         """
@@ -295,7 +295,8 @@ def get_mapping(self):
     def extract_document(self, data):
         doc = {}
 
-        attrs = ('id', 'project', 'title', 'headers', 'version', 'path', 'content', 'taxonomy', 'commit')
+        attrs = ('id', 'project', 'title', 'headers', 'version', 'path',
+                 'content', 'taxonomy', 'commit')
         for attr in attrs:
             doc[attr] = data.get(attr, '')
 

readthedocs/search/parse_json.py

@@ -18,7 +18,8 @@ def process_all_json_files(version, build_dir=True):
     if build_dir:
         full_path = version.project.full_json_path(version.slug)
     else:
-        full_path = version.project.get_production_media_path(type='json', version_slug=version.slug, include_file=False)
+        full_path = version.project.get_production_media_path(
+            type='json', version_slug=version.slug, include_file=False)
     html_files = []
     for root, dirs, files in os.walk(full_path):
         for filename in fnmatch.filter(files, '*.fjson'):
@@ -110,6 +111,7 @@ def process_file(filename):
     return {'headers': headers, 'content': body_content, 'path': path,
             'title': title, 'sections': sections}
 
+
 def recurse_while_none(element):
     if element.text is None:
         return recurse_while_none(element.getchildren()[0])

readthedocs/search/utils.py

@@ -16,7 +16,8 @@ def process_mkdocs_json(version, build_dir=True):
     if build_dir:
         full_path = version.project.full_json_path(version.slug)
     else:
-        full_path = version.project.get_production_media_path(type='json', version_slug=version.slug, include_file=False)
+        full_path = version.project.get_production_media_path(
+            type='json', version_slug=version.slug, include_file=False)
 
     html_files = []
     for root, dirs, files in os.walk(full_path):
@@ -32,9 +33,13 @@ def process_mkdocs_json(version, build_dir=True):
             title = sections[0]['title']
         except IndexError:
             title = relative_path
-        page_list.append(
-            {'content': html, 'path': relative_path, 'title': title, 'headers': headers, 'sections': sections}
-        )
+        page_list.append({
+            'content': html,
+            'path': relative_path,
+            'title': title,
+            'headers': headers,
+            'sections': sections,
+        })
     return page_list
 
 

readthedocs/search/views.py

@@ -30,6 +30,7 @@
 log = logging.getLogger(__name__)
 LOG_TEMPLATE = u"(Elastic Search) [{user}:{type}] [{project}:{version}:{language}] {msg}"
 
+
 def elastic_search(request):
     """
     Use elastic search for global search
@@ -50,7 +51,9 @@ def elastic_search(request):
         if type == 'project':
             results = search_lib.search_project(request, query, language=language)
         elif type == 'file':
-            results = search_lib.search_file(request, query, project=project, version=version, taxonomy=taxonomy)
+            results = search_lib.search_file(request, query, project=project,
+                                             version=version,
+                                             taxonomy=taxonomy)
 
     if results:
         # pre and post 1.0 compat