Resolve linting messages in readthedocs.rtd_tests.*

Author: gregmuellegger

readthedocs/rtd_tests/base.py

@@ -61,7 +61,9 @@ def post_step(self, step, **data):
         self.assertIsNotNone(resp)
         return resp
 
-    def assertWizardResponse(self, response, step=None):
+    # We use camelCase on purpose here to conform with unittest's naming
+    # conventions.
+    def assertWizardResponse(self, response, step=None):  # noqa
         '''Assert successful wizard response'''
         # Is is the last form
         if step is None:
@@ -84,7 +86,9 @@ def assertWizardResponse(self, response, step=None):
             self.assertIn('{0}-current_step'.format(self.wizard_class_slug),
                           response.content)
 
-    def assertWizardFailure(self, response, field, match=None):
+    # We use camelCase on purpose here to conform with unittest's naming
+    # conventions.
+    def assertWizardFailure(self, response, field, match=None):  # noqa
         '''Assert field threw a validation error
 
         response

readthedocs/rtd_tests/factories/comments_factories.py

@@ -23,12 +23,12 @@ class DocumentNodeFactory(factory.DjangoModelFactory):
     page = "page-about-nothing"
 
     @classmethod
-    def _create(self, *args, **kwargs):
+    def _create(cls, *args, **kwargs):
         if not kwargs.get('hash'):
             kwargs['hash'] = random.getrandbits(128)
         if not kwargs.get('commit'):
             kwargs['commit'] = random.getrandbits(128)
-        return super(DocumentNodeFactory, self)._create(*args, **kwargs)
+        return super(DocumentNodeFactory, cls)._create(*args, **kwargs)
 
 
 class DocumentCommentFactory(factory.DjangoModelFactory):

readthedocs/rtd_tests/factories/general_factories.py

@@ -7,7 +7,6 @@ class UserFactory(factory.Factory):
 
     username = factory.Sequence(lambda n: 'joe %s' % n)
 
-
     @classmethod
     def _prepare(cls, create, password="password_sentinel", **kwargs):
         '''

readthedocs/rtd_tests/fixtures/__init__.py

@@ -1 +0,0 @@
-#.

readthedocs/rtd_tests/mocks/mock_api.py

@@ -4,12 +4,13 @@
 
 # Mock tastypi API.
 
+
 class ProjectData(object):
     def get(self):
         return dict()
 
 
-def mockVersion(repo):
+def mock_version(repo):
     class MockVersion(object):
         def __init__(self, x=None):
             pass
@@ -65,13 +66,13 @@ def get(self, **kwargs):
             if 'slug' in kwargs:
                 return {'objects': [version], 'project': project}
             else:
-              return version
+                return version
     return MockVersion
 
 
 class MockApi(object):
     def __init__(self, repo):
-        self.version = mockVersion(repo)
+        self.version = mock_version(repo)
 
     def project(self, x):
         return ProjectData()