Skip to content

Commit 5a4f3d5

Browse files
committed
Merge branch 'humitos/redirects-at-db-level' of github.com:readthedocs/readthedocs.org into humitos/redirects-at-db-level
2 parents 45ed017 + 067934e commit 5a4f3d5

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

readthedocs/proxito/views/serve.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -100,15 +100,9 @@ def get(self,
100100

101101
return HttpResponseRedirect(new_path)
102102

103-
# Don't do auth checks
104-
# try:
105-
# Version.objects.public(user=request.user, project=final_project).get(slug=version_slug) # noqa
106-
# except Version.DoesNotExist:
107-
# # Properly raise a 404 if the version doesn't exist (or is inactive) and
108-
# # a 401 if it does
109-
# if final_project.versions.filter(slug=version_slug, active=True).exists():
110-
# return _serve_401(request, final_project)
111-
# raise Http404('Version does not exist.')
103+
# Check user permissions and return an unauthed response if needed
104+
if not self.allowed_user(request, final_project, version_slug):
105+
return self.get_unauthed_response(request, final_project)
112106

113107
storage_path = final_project.get_storage_path(
114108
type_='html', version_slug=version_slug, include_file=False
@@ -122,6 +116,9 @@ def get(self,
122116

123117
return self._serve_docs(request, final_project=final_project, path=path)
124118

119+
def allowed_user(self, *args, **kwargs):
120+
return True
121+
125122

126123
class ServeDocs(SettingsOverrideObject):
127124
_default_class = ServeDocsBase

0 commit comments

Comments
 (0)