Skip to content

Commit 067934e

Browse files
authored
Merge branch 'master' into humitos/redirects-at-db-level
2 parents 662ceb8 + d90f37d commit 067934e

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

readthedocs/proxito/views/serve.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -95,15 +95,9 @@ def get(self,
9595

9696
return HttpResponseRedirect(new_path)
9797

98-
# Don't do auth checks
99-
# try:
100-
# Version.objects.public(user=request.user, project=final_project).get(slug=version_slug) # noqa
101-
# except Version.DoesNotExist:
102-
# # Properly raise a 404 if the version doesn't exist (or is inactive) and
103-
# # a 401 if it does
104-
# if final_project.versions.filter(slug=version_slug, active=True).exists():
105-
# return _serve_401(request, final_project)
106-
# raise Http404('Version does not exist.')
98+
# Check user permissions and return an unauthed response if needed
99+
if not self.allowed_user(request, final_project, version_slug):
100+
return self.get_unauthed_response(request, final_project)
107101

108102
storage_path = final_project.get_storage_path(
109103
type_='html', version_slug=version_slug, include_file=False
@@ -117,6 +111,9 @@ def get(self,
117111

118112
return self._serve_docs(request, final_project=final_project, path=path)
119113

114+
def allowed_user(self, *args, **kwargs):
115+
return True
116+
120117

121118
class ServeDocs(SettingsOverrideObject):
122119
_default_class = ServeDocsBase

0 commit comments

Comments
 (0)