This repository was archived by the owner on Apr 8, 2025. It is now read-only.
CI: use circleci #76
Merged
CI: use circleci #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
force-pushed
the
circleci
branch
4 times, most recently
from
117ba99 to
4dbed8d
Compare
|
We are almost there :D only one test is falling on firefox, will check tomorrow. |
ericholscher
approved these changes
Dec 17, 2020
| sphinx31: Sphinx<3.2 | ||
| sphinx32: Sphinx<3.3 | ||
| sphinx33: Sphinx<3.4 | ||
| sphinxlatest: Sphinx |
There was a problem hiding this comment.
I think we can probably scope this down a bit and only test against the latest release of each version? Similar to python: sphinx1, sphinx2, sphinx3?
There was a problem hiding this comment.
I noticed that there was a "half-breaking" change in 2.4 and 2.5 (the jquery change). But I'm +1 on supporting the latest versions of each mayor release. Less time waiting.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with the test was that it was assuming that the inner real width/height was the same the given by the test, but this doesn't count with extra space generated for window borders, navigation bar, etc (
set_viewport_sizeuses this too).This was failing only for firefox. Also, the current test was just assuming the margins were the same size (dividing by 2), instead I'm just checking that the margins are almost the same size (since we want to check that the modal is in the middle).