This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Put the JS embed back into script_files #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the inline comment suggests, there are issues with putting the JS embed into the extrahead. A theme that puts scripts at the end of the body (none of the major themes do this) may not have loaded jquery before this script is executed and the script will error.
agjohnson
approved these changes
Jul 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the inline comment suggests, there are issues with putting the JS embed into the extrahead. A theme that puts scripts at the end of the body (none of the major themes do this) may not have loaded jquery before this script is executed and the script will error.