This repository was archived by the owner on Apr 8, 2025. It is now read-only.
setup.py fixes #79
Merged
setup.py fixes #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mgorny
commented
Mar 3, 2020
mgorny
commented
- remove broken distutils compatibility code
- stop installing tests
- make setup.py +x
The distutils compat might be meaningful if the code did not unconditionally call find_packages() (which is undefined in that branch). That said, there's probably no reason whatever why this package would need such compat (i.e. be installed before setuptools), so let's just drop it.
Add a missing exclude to find_packages() in order to stop it from installing global-scope 'tests' package. Fixes readthedocs#64
Make setup.py executable so that it can be executed directly. This is not strictly necessary but it's convenient.
stsewd
reviewed
Mar 17, 2020
| package_dir={'': '.'}, | ||
| packages=find_packages('.'), | ||
| packages=find_packages('.', exclude=['tests']), |
There was a problem hiding this comment.
Not sure about this, but I think some distributions run the tests after installing a package, so they expect them to be included
There was a problem hiding this comment.
Distributions usually run tests before building the package. According to my testing, setup.py sdist still includes them in the tarball. If you want them to be usable after installing the package, they need to be moved inside the package. Installing a global scope tests package is a very bad idea, and guaranteed to cause problems when done by more than one package.
There was a problem hiding this comment.
That makes sense to me, I also saw #60
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.