Install imagemagick package
#80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
reviewed
Nov 15, 2018
| @@ -48,6 +48,10 @@ RUN apt-get -y install \ | |||
| latex-cjk-chinese-arphic-gbsn00lp latex-cjk-chinese-arphic-gkai00mp \ | |||
| fonts-symbola | |||
|
|
|||
| # Install imagemagick to support sphinx.ext.imgconverter | |||
| # http://www.sphinx-doc.org/en/master/usage/extensions/imgconverter.html | |||
| RUN apt-get -y install imagemagick | |||
There was a problem hiding this comment.
Do we want a separate layer for just this dependency or should this be bundled up in another step? I think we need to reduce the number of layers here, and can squash a lot of our operations.
There was a problem hiding this comment.
I'm not sure how this affects the image in the end. I think it's related to the size of the resulting image but it will need further research from my side to have an opinion here.
stsewd
approved these changes
Nov 16, 2018
humitos
added a commit
that referenced
this pull request
Jan 2, 2019
humitos
added a commit
that referenced
this pull request
Jan 2, 2019
humitos
added a commit
that referenced
this pull request
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to readthedocs/readthedocs.org#3979