Skip to content

Upgrade CONDA_VERSION to the latest version #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

browniebroke
Copy link
Contributor

@browniebroke browniebroke commented Oct 8, 2018

Take over from stale PR #69 with requested changes. Pipenv is broken currently but a fix is done on their master branch so I had to install from Github to get the build to pass (see previous commits).

Fixes #68

EDIT: Pipenv has been released with a fix, so reverted to use the one from PyPI.

@browniebroke browniebroke changed the title Upgrade CONDA_VERSION Fix the build on master Oct 8, 2018
@browniebroke browniebroke force-pushed the update-conda-version-2 branch from fc8e480 to 3a40dab Compare October 9, 2018 11:49
@browniebroke browniebroke changed the title Fix the build on master Upgrade CONDA_VERSION to the latest version Oct 9, 2018
@browniebroke browniebroke mentioned this pull request Oct 9, 2018
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is ready to be merged to me.

@browniebroke
Copy link
Contributor Author

Closing in favor of #73 which is now merged.

@browniebroke browniebroke deleted the update-conda-version-2 branch November 6, 2018 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated CONDA_VERSION causes PRs to fail
3 participants