Skip to content

Add Python 3.7 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 6, 2018
Merged

Add Python 3.7 #73

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a403a00
Update CONDA_VERSION
osteele Jun 18, 2018
732f685
Revert unwanted change
Oct 8, 2018
3c06f64
Update conda to the latest version 4.5.11
Oct 8, 2018
102d846
Add Python 3.7 to the Docker image
Oct 8, 2018
265339e
Add Python 3.7 to the README
Oct 8, 2018
479a5d9
Update Python 3.7.x to 3.7.1
browniebroke Oct 21, 2018
7af8cdb
Remove duplicated line
humitos Nov 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,12 @@ ENV LANG C.UTF-8
ENV PYTHON_VERSION_27 2.7.14
ENV PYTHON_VERSION_35 3.5.5
ENV PYTHON_VERSION_36 3.6.4
ENV CONDA_VERSION 4.4.10
ENV PYTHON_VERSION_37 3.7.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note from Python 3.7 release schedule:

3.7.1 final: 2018-10-18 (expected)

We might want to hold this one for a bit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose, yes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I'll update this PR when 3.7.1 gets released

ENV CONDA_VERSION 4.5.11
LABEL python.version_27=$PYTHON_VERSION_27
LABEL python.version_35=$PYTHON_VERSION_35
LABEL python.version_36=$PYTHON_VERSION_36
LABEL python.version_37=$PYTHON_VERSION_37
LABEL conda.version=$CONDA_VERSION

# System dependencies
Expand Down Expand Up @@ -74,10 +76,12 @@ ENV PATH /home/docs/.pyenv/shims:$PATH:/home/docs/.pyenv/bin

# Install supported Python versions
RUN pyenv install $PYTHON_VERSION_27 && \
pyenv install $PYTHON_VERSION_37 && \
pyenv install $PYTHON_VERSION_36 && \
pyenv install $PYTHON_VERSION_35 && \
pyenv global \
$PYTHON_VERSION_27 \
$PYTHON_VERSION_37 \
$PYTHON_VERSION_36 \
$PYTHON_VERSION_35

Expand All @@ -88,6 +92,12 @@ RUN pyenv local $PYTHON_VERSION_27 && \
pyenv exec pip install --only-binary numpy,scipy numpy scipy && \
pyenv exec pip install pandas matplotlib virtualenv

RUN pyenv local $PYTHON_VERSION_37 && \
pyenv exec pip install -U pip && \
pyenv exec pip install --only-binary numpy,scipy numpy scipy && \
pyenv exec pip install pandas matplotlib virtualenv
pyenv exec pip install pandas matplotlib virtualenv

RUN pyenv local $PYTHON_VERSION_36 && \
pyenv exec pip install -U pip && \
pyenv exec pip install --only-binary numpy,scipy numpy scipy && \
Expand Down
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ repositoryr:

`readthedocs/build:4.0rc1`
**testing**
Ubuntu 18.04 release candidate supporting Python 2.7, 3.5, 3.6. For internal
Ubuntu 18.04 release candidate supporting Python 2.7, 3.5, 3.6, 3.7. For internal
development **testing** only, not available for public usage yet.

.. _readthedocs/build: https://hub.docker.com/r/readthedocs/build/
Expand Down