Skip to content

Add missing pyenv build dependency #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2018
Merged

Add missing pyenv build dependency #66

merged 2 commits into from
Apr 27, 2018

Conversation

humitos
Copy link
Member

@humitos humitos commented Apr 27, 2018

@humitos humitos added Improvement Minor improvement to code PR: ready for review labels Apr 27, 2018
@humitos humitos force-pushed the humitos/pyenv/missing-dep branch 2 times, most recently from 9c207e0 to e758afb Compare April 27, 2018 15:01
@humitos
Copy link
Member Author

humitos commented Apr 27, 2018

I don't understand why we have two check and why the pr failed :/

@humitos humitos force-pushed the humitos/pyenv/missing-dep branch from e758afb to 1139628 Compare April 27, 2018 15:22
agjohnson
agjohnson approved these changes Apr 27, 2018
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@humitos humitos merged commit 9b0816d into master Apr 27, 2018
@humitos humitos deleted the humitos/pyenv/missing-dep branch April 27, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @agjohnson