-
Notifications
You must be signed in to change notification settings - Fork 70
use the latest version of miniconda #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this will likely fix bugs that appear from older versions of conda
I think it would be best to have this be pinned to a specific version. I don't want it to update every time we run Docker, as that could leave us with random versions that are broken. |
@ericholscher is that good? |
@ericholscher is there anything specific that would help this get merged. We're very eager to use the new conda with our documentation (otherwise it doesn't build). If there is anything we can do to speed things up (help, unfortunately not money as we're from academia and are poor 😉 ) |
@wkerzendorf thanks for the PR! I was just going to make this change myself. This PR looks fine, would you also like to backport this to the releases/2.x branch? |
@agjohnson let me know if I can help with backport |
@wkerzendorf feel free to apply on a separate PR against |
@agjohnson does that mean - it will work now? |
@agjohnson and its now not linked to the latest. Should we pin it to latest? |
No, we rather pin to explicit versions to remove any surprises. We do this across all of our dependencies to reduce operations load. |
Oh and no, image won't work immediately. It takes hours to build and I likely won't install until later tonight or tomorrow. |
@agjohnson unfortunately it still isn't installed - any ETA? |
Didn't get to it today, this will be on my list next week. We avoid ops changes on weekends. |
this will likely fix bugs that appear from older versions of conda and is in relation to issue readthedocs/readthedocs.org#3150