Skip to content

use the latest version of miniconda #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2017

Conversation

wkerzendorf
Copy link
Contributor

this will likely fix bugs that appear from older versions of conda and is in relation to issue readthedocs/readthedocs.org#3150

this will likely fix bugs that appear from older versions of conda
@ericholscher
Copy link
Member

I think it would be best to have this be pinned to a specific version. I don't want it to update every time we run Docker, as that could leave us with random versions that are broken.

@wkerzendorf
Copy link
Contributor Author

@ericholscher is that good?

@wkerzendorf
Copy link
Contributor Author

@ericholscher is there anything specific that would help this get merged. We're very eager to use the new conda with our documentation (otherwise it doesn't build). If there is anything we can do to speed things up (help, unfortunately not money as we're from academia and are poor 😉 )

@agjohnson
Copy link
Contributor

@wkerzendorf thanks for the PR! I was just going to make this change myself. This PR looks fine, would you also like to backport this to the releases/2.x branch?

@agjohnson agjohnson self-requested a review October 19, 2017 16:28
@wkerzendorf
Copy link
Contributor Author

@agjohnson let me know if I can help with backport

@agjohnson
Copy link
Contributor

@wkerzendorf feel free to apply on a separate PR against releases/2.x, I can get this PR merged now though.

@agjohnson agjohnson merged commit 3e80d69 into readthedocs:master Oct 19, 2017
@wkerzendorf wkerzendorf deleted the patch-1 branch October 19, 2017 17:04
@wkerzendorf
Copy link
Contributor Author

@agjohnson does that mean - it will work now?

@wkerzendorf
Copy link
Contributor Author

@agjohnson and its now not linked to the latest. Should we pin it to latest?

@agjohnson
Copy link
Contributor

No, we rather pin to explicit versions to remove any surprises. We do this across all of our dependencies to reduce operations load.

@agjohnson
Copy link
Contributor

Oh and no, image won't work immediately. It takes hours to build and I likely won't install until later tonight or tomorrow.

@wkerzendorf
Copy link
Contributor Author

@agjohnson unfortunately it still isn't installed - any ETA?

@agjohnson
Copy link
Contributor

Didn't get to it today, this will be on my list next week. We avoid ops changes on weekends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants