Skip to content

Update conda path #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Update conda path #26

merged 1 commit into from
Mar 8, 2017

Conversation

agjohnson
Copy link
Contributor

I don't know if we need to change the conda version, but this installs into a
path that copies that pyenv installation pattern from our latest image

@agjohnson agjohnson added the PR: work in progress Pull request is not ready for full review label Mar 8, 2017
@agjohnson agjohnson requested a review from ericholscher March 8, 2017 03:14
@agjohnson agjohnson added PR: ready for review and removed PR: work in progress Pull request is not ready for full review labels Mar 8, 2017
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should retag it possibly as well, if you want this in prod.

@agjohnson
Copy link
Contributor Author

I'm going to reuse 2.0 tag, as that's the easiest and there are a number of issues around versioning this like a module. I'll open a ticket to discuss versioning more.

@agjohnson agjohnson merged commit 41f4d42 into releases/2.x Mar 8, 2017
@agjohnson agjohnson deleted the conda-path branch March 8, 2017 18:35
@agjohnson
Copy link
Contributor Author

Oh! Docker hub is smarter than I thought. I think we can follow semver here, with some modifications. I think we can update the version in the label to include bug fix level version number, and tag with a bug fix level version number (2.0.1), but have docker hub build on a tag via regex lookup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants