Skip to content

add plantuml package #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2017
Merged

add plantuml package #20

merged 1 commit into from
Feb 7, 2017

Conversation

petrjasek
Copy link
Contributor

replaces #17

@ericholscher
Copy link
Member

This looks pretty straight forward. However, I know we have generally not added random dependencies in the past. This does seem like a useful one to have on our build systems, so I'm inclined to 👍 it, @agjohnson thoughts?

agjohnson
agjohnson approved these changes Feb 7, 2017
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this should be fine. The original problem including this was an unvetted PPA, but I'm more inclined to include packages if they are included in LTS.

@agjohnson agjohnson merged commit 5b02ef2 into readthedocs:master Feb 7, 2017
@agjohnson
Copy link
Contributor

Also, we're still putting together support in RTD for this image, so it will be a short while before this image is live. I think eventually, there should be an easier method of self-selecting into our development image, but for now it requires some admin help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petrjasek @ericholscher @agjohnson