Backport version tests on 6.x image #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the image is built from the current commit, we spin up the container with the image just built and execute some commands to check the versions them.
It will download the image from Docker Hub and use its layers as cache.
PIP_VERSION and VIRTUALENV_VERSION are sensible variables that are read by pip and virtualenv respectively and we already have issues with them. So, to avoid this problem and future ones, we are prefixing all of our variables with `RTD_`.
We can't use `--cache-from` because the `apt-get update` command is used from cache and that could make the package versions/URLs to be outdated and fail.
|
Merging to start building the Docker Hub images and be able to deploy them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring all the commits from #143 into
releases/6.xto run tests on this branch as well.