This repository was archived by the owner on Mar 18, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes with readthedocs/readthedocs.org#2507.
That PR adds custom conda channel support to the config parser; this one adds validation for those config options. It also adds tests for the validation.
I'm intentionally curtailing some of the functionality of conda here.
conda -c $CHANNEL
has support for 3 different kinds of input; here's the relevant help section:It seems like a needless security issue to provide any of the valid inputs as working options here. Any time a system exposes its filesystem to open web handling I get itchy under the collar. So, I opted to limit valid channels to only being ones hosted at the
channel_alias
(conda.anaconda.org
, presumably, though your deployment may vary). I did my best to tighten up the testing and validation on those checks, though I'm sure I missed something.