-
Notifications
You must be signed in to change notification settings - Fork 124
Initial structure for documentation project #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start, but I'd love to see what the README looks like. That's going to be the users primary interaction point, so that's going to be where we really need to focus on making sure the content is nice and works well.
@ericholscher I made some more extensive updates now, making the example project a bit more "self-serving". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Lots of little nitpicks and style things, but overall I really like the content and think it's very close.
@@ -0,0 +1,24 @@ | |||
.. include:: ../README.rst | |||
|
|||
Welcome to Lumache's documentation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like a really odd transition without context on the index page. Should this be on another subpage that we link to from the Rendered
docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of agree... it's an attempt to have an example project while at the same time showing how we would document a fictive software project. So this content would normally be in the index.rst page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely want to merge this before shipping the main PR, so 👍 'ing it as well, since I think it's really close
Co-authored-by: Eric Holscher <[email protected]>
Co-authored-by: Eric Holscher <[email protected]>
Co-authored-by: Eric Holscher <[email protected]>
Thanks for the great and super-helpful review @ericholscher 🙏 |
Proposal for a basic Sphinx example.
Scope:
All comments and suggestions that can help to achieve the above are much appreciated.