Warning page for invalid Hook calls #1613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@threepointone Tried to add you as reviewer but you don't show up for this repo, I think you need to add yourself |
|
Deploy preview for reactjs ready! Built with commit 93446b6 |
threepointone
approved these changes
Feb 1, 2019
|
|
||
| npm ls react | ||
|
|
||
| If you see more than one React, you'll need to figure out why this happens, and fix your dependency tree. For example, maybe a library you're using incorrectly specifies `react` as a dependency (rather than a peer dependency). Until such a library is fixed, [Yarn resolutions](https://yarnpkg.com/lang/en/docs/selective-version-resolutions/) is one possible workaround. |
There was a problem hiding this comment.
Suggested change
| If you see more than one React, you'll need to figure out why this happens, and fix your dependency tree. For example, maybe a library you're using incorrectly specifies `react` as a dependency (rather than a peer dependency). Until such a library is fixed, [Yarn resolutions](https://yarnpkg.com/lang/en/docs/selective-version-resolutions/) is one possible workaround. | |
| If you see more than one React, you'll need to figure out why this happens, and fix your dependency tree. For example, maybe a library you're using incorrectly specifies `react` as a dependency (rather than a peer dependency). Until that library is fixed, [Yarn resolutions](https://yarnpkg.com/lang/en/docs/selective-version-resolutions/) is one possible workaround. |
BetterZxx
pushed a commit
to BetterZxx/react.dev
that referenced
this pull request
Mar 21, 2023
* add warning for invalid hook call * Fix versions * Split code examples * unnecessary comma * tweaks * Update content/warnings/invalid-hook-call-warning.md Co-Authored-By: gaearon <[email protected]> * nit
BetterZxx
pushed a commit
to BetterZxx/react.dev
that referenced
this pull request
Mar 21, 2023
* Update docs for stable Hooks * Add Hooks to reference page * Reword intro * Tweak refwording * Hooks blog post draft * Link to roadmap from post * Add more details * Update and rename 2019-01-30-react-v16.8.0.md to 2019-02-04-react-v16.8.0.md * changelog updates * review tweaks * Mention type defs * add warning for invalid hook call * Warning page for invalid Hook calls (reactjs#1613) * add warning for invalid hook call * Fix versions * Split code examples * unnecessary comma * tweaks * Update content/warnings/invalid-hook-call-warning.md Co-Authored-By: gaearon <[email protected]> * nit * Update 2019-02-04-react-v16.8.0.md * Thanks Sophie * Update 2019-02-04-react-v16.8.0.md * Revert "add warning for invalid hook call" This reverts commit e301239. * Tweaks * Docs updates * Point to codesandbox and usehooks as community examples * tweaks * testing * Renamed Hooks blog/date * Udpated changelog * Replaced inaccurate comments * Added ReactTestUtils.act() to CHANGELOG * Moved blog post to Feb 6th * Update version number in header and versions page * Updated 16.8 CHANGELOG wording to also mention ReactTestRenderer.act() * Fix typo on hooks availability Might make people that are going through the docs confused. * React Native will ship hooks in its 0.59 release. (reactjs#1633) * Added link to 16.7 docs * Port external gatsby-remark-autolink-headers plugin * Implement custom-id syntax on headings * Replace keys when inserting style/script tags * react-testing-library now supports `act` (reactjs#1635) * react-testing-library now supports `act` * fix typo * Document test renderer act (temporary fix) * Use 16.8.1 (reactjs#1638)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-1613--reactjs.netlify.com/warnings/invalid-hook-call-warning.html