Enhance java doc #97
Enhance java doc #97
Conversation
| @@ -3,6 +3,8 @@ | |||
| /** | |||
| * A Processor represents a processing stage—which is both a {@link Subscriber} | |||
| * and a {@link Publisher} and obeys the contracts of both. | |||
| * @param <T> the Type of element signaled to the {@link Subscriber} | |||
There was a problem hiding this comment.
Is Type intended to be capitalized?
There was a problem hiding this comment.
No, but as used in Subscriber java doc.
There was a problem hiding this comment.
Great that you followed the convention. What would you propose? Type or type?
There was a problem hiding this comment.
Deal! :)
Would you mind updating the other files?
|
@ouertani, thanks for helping out! We're following https://github.com/reactive-streams/reactive-streams/blob/master/CONTRIBUTING.md for contributions, please read and adjust PR accordingly. |
|
LGTM |
|
@reactive-streams/contributors Can we merge this? |
|
@reactive-streams/contributors any update please ? |
|
👍 from me, @reactive-streams/contributors please vote before 24 Oct GMT+0 or this gets merged. |
|
@reactive-streams/contributors Merging without objections. |
|
@ouertani Can you rebase on top of current master? |
ouertani
force-pushed
the
enhance-javaDoc
branch
from
f93e158 to
f344818
Compare
|
@viktorklang rebased on the top of current master done. |
|
Thanks @ouertani! |
No description provided.