Augments the size of Subscription.request(n) from int to long and adds a... #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a spec provision that a cumulative demand of Long.MAX_VALUE MAY be treated as 'effectively unbounded'
This was referenced Jul 14, 2014
Closed
|
LGTM |
|
👍 |
1 similar comment
|
👍 |
|
@mariusaeriksen @purplefox @normanmaurer @DougLea @GavinBierman Yay or Nay? |
|
Yes. This was one of my initial suggestions about API back in January, so I'm happy to see it back in the spec! |
|
Everyone has been given ample time to respond at least saying that they need more time to think about it. |
|
Go for it :) |
|
Easier to ask forgiveness and to try often! |
|
@smaldini Lol. I just want to make sure no one feels steamrolled. |
|
I say we move forward. |
|
+1, merging since there's been 7 days grace period |
viktorklang
added a commit
that referenced
this pull request
Jul 22, 2014
Augments the size of Subscription.request(n) from int to long and adds a...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... spec provision that a cumulative demand of Long.MAX_VALUE MAY be treated as 'effectively unbounded'
See #62