Skip to content

Do not build on JDK 13. #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Do not build on JDK 13. #532

merged 1 commit into from
Jun 15, 2021

Conversation

akarnokd
Copy link
Contributor

Java 6 is no longer available as target in 13. Removing that build target.

@viktorklang
Copy link
Contributor

viktorklang commented Jun 15, 2021 via email

@rkuhn
Copy link
Member

rkuhn commented Jun 15, 2021

Yes, this should fix it—we may want to discuss for how long we want to keep JDK 6 compatibility.

@rkuhn
Copy link
Member

rkuhn commented Jun 15, 2021

question regarding DCO: is this required?

@viktorklang
Copy link
Contributor

viktorklang commented Jun 15, 2021 via email

@rkuhn
Copy link
Member

rkuhn commented Jun 15, 2021

In this case: @akarnokd please add a --signoff to your commit (as described behind the Details link for DCO)—and thanks for the quick response!

Signed-off-by: Dávid Karnok <[email protected]>
@akarnokd
Copy link
Contributor Author

@rkuhn done.

@rkuhn rkuhn merged commit 899f17f into reactive-streams:master Jun 15, 2021
@akarnokd akarnokd deleted the patch-3 branch June 15, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants