Fix TCK §2.3 verification for when a legit call is made with onError/onComplete method name in the stacktrace #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onError/onComplete method name in the stacktrace
This was referenced Feb 27, 2020
|
Should also fix #460 |
|
Thanks @akarnokd! 👍 @reactive-streams/contributors LGTM or not? |
|
Thanks @akarnokd! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the TCK verifying rule §2.3 would fail if the call stack contained any method named
onCompleteoronError, even if they were not on the call chain initiated by the test'sonError/onComplete.Related #481, microprofile/microprofile-reactive-streams-operators#131
Resolves #460