Upgrade to Gradle 6.0.1, TestNG 7.0.0, use Bnd for OSGi properties #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
viktorklang
reviewed
Dec 4, 2019
api/build.gradle
Outdated
| 'Bundle-Description': 'Reactive Streams API', | ||
| 'Bundle-DocURL': 'http://reactive-streams.org', | ||
| 'Bundle-Version': project.version, | ||
| 'Import-Package': '!org.junit,!junit.framework,!org.mockito.*,!org.testng.*,*', |
There was a problem hiding this comment.
Are these needed for all the jars?
There was a problem hiding this comment.
It used to be an import bloat with OSGi due to it including test dependencies. I'll double check.
There was a problem hiding this comment.
Yep, they are no longer necessary, plus the TestNG imports have to be named for the TCK bundle anyway.
viktorklang
requested changes
Dec 4, 2019
There was a problem hiding this comment.
Approved after question of import-packages has been answered.
Very nice work @akarnokd—thank you!
@reactive-streams/contributors Please take this opportunity to review.
|
Thanks for fixing this, @akarnokd! Very appreciated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to Gradle 6 requires using the Bnd plugin and a slightly different way to define OSGi parameters.
In addition, Gradle complains about
compilebeing deprecated and thus have been upgraded toapi/implementationuse.Third, TestNG has been updated to the latest because that 5.10.4 won't run under Eclipse as its plugin stopped supporting 5 some time ago afaik. In consequence, one of the methods had to be annotated as non-testable because TestNG tries to inject parameters into public methods of a test-annotated class.