Making debug message formatting disabled when debug is disabled #447
Conversation
|
@reactive-streams/contributors Pretty non-controversial PR, so I'll merge this shortly. |
|
thanks for the quick fix! I've tested it and the performance is better. I wonder if it'd be best to try a more generic solution, though. There's still a lot of string formatting because of other methods of |
|
@fwbrasil You're most welcome! I'm not sure it makes 100% sense to spend a lot of effort in optimizing what is essentially only executed at test time, That being said, if you can demonstrate significant gains with non-breaking changes—I'm sure it'd be an interesting enhancement! ^^ |
| @@ -504,7 +504,8 @@ public TestSetup apply(Long aLong) throws Throwable { | |||
|
|
|||
| @Override | |||
| public void onSubscribe(final Subscription subscription) { | |||
| env.debug(String.format("whiteboxSubscriber::onSubscribe(%s)", subscription)); | |||
| if (env.debugEnabled()) | |||
There was a problem hiding this comment.
Needs curly braces to adhere to codebase style.
There was a problem hiding this comment.
@JakeWharton Good point—addressed!
viktorklang
force-pushed
the
wip-446-tckperf-√
branch
from
201dc6c to
3b1664b
Compare
|
@reactive-streams/contributors Merging. |
Fixes #446