Preparations for 1.0.2-RC1—incl. release notes. #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
akarnokd
reviewed
Dec 1, 2017
RELEASE-NOTES.md
Outdated
| - Specification | ||
| + Glossary term added for `Thread-safe` | ||
| + No breaking/semantical changes | ||
| + Rule [clarifications](#specification-clarifications-1.0.2-RC1) |
There was a problem hiding this comment.
The . in these links are removed by GitHub's markdown and the URL becomes:
RELEASE-NOTES.md#specification-clarifications-102-rc1
There was a problem hiding this comment.
Nice catch, thanks @akarnokd!
akarnokd
reviewed
Dec 1, 2017
| @@ -42,7 +42,7 @@ subprojects { | |||
| instructionReplace "Bundle-Vendor", "Reactive Streams SIG" | |||
| instructionReplace "Bundle-Description", "Reactive Streams API" | |||
| instructionReplace "Bundle-DocURL", "http://reactive-streams.org" | |||
| instructionReplace "Bundle-Version", "1.0.1" | |||
| instructionReplace "Bundle-Version", "1.0.2-RC1" | |||
There was a problem hiding this comment.
instructionReplace "Bundle-Version", $version ?
There was a problem hiding this comment.
I think String interpolation should work here (but I can be never sure with Gradle):
instructionReplace "Bundle-Version", "$version"
There was a problem hiding this comment.
For some awkward reason "$version" will generate "1.0.1.RC1" iso "1.0.1-RC1" :S
smaldini
approved these changes
Dec 1, 2017
akarnokd
approved these changes
Dec 1, 2017
ktoso
reviewed
Dec 5, 2017
| @@ -6,6 +6,5 @@ tests: | |||
| classes: | |||
| - org.reactivestreams.tck.IdentityProcessorVerificationDelegationTest | |||
| - org.reactivestreams.tck.PublisherVerificationTest | |||
| - org.reactivestreams.tck.BokenExampleTest | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@reactive-streams/contributors This is the preparation for 1.0.2-RC1,
I'd like to issue it before the end of the week, so please provide feedback ASAP if you're interested in vetting the release notes etc.