Add SubmissionPublisher TCK test #415
Conversation
|
Travis still runs with Java 9.0.0 :( |
| public void run() { | ||
| while (sp.getNumberOfSubscribers() == 0) { | ||
| try { | ||
| Thread.sleep(1); |
There was a problem hiding this comment.
Thread.onSpinWait()? :)
| } | ||
| } | ||
|
|
||
| for (int i = 0; i < elements; i++) { |
There was a problem hiding this comment.
Perhaps add && sp.getNumberOfSubscribers() > 0 ?
There was a problem hiding this comment.
I think if there are no subscribers, the loop will rush through without blocking.
| } | ||
|
|
||
| for (int i = 0; i < elements; i++) { | ||
| sp.submit(i); |
There was a problem hiding this comment.
Does this stop blocking if all subscribers cancel their subscriptions?
There was a problem hiding this comment.
I guess so. This test passes for me:
SubmissionPublisher<Integer> sp = new SubmissionPublisher<>(
ForkJoinPool.commonPool(), 1);
TestConsumer<Integer> tc1 = new TestConsumer<>(0L);
TestConsumer<Integer> tc2 = new TestConsumer<>(0L);
sp.subscribe(tc1);
sp.subscribe(tc2);
CountDownLatch cdl = new CountDownLatch(1);
SchedulerServices.single().schedule(() -> {
for (int i = 0; i < 512; i++) {
sp.submit(i);
}
cdl.countDown();
});
Thread.sleep(1000);
assertEquals(1, cdl.getCount());
tc1.cancel();
tc2.cancel();
assertTrue(cdl.await(5, TimeUnit.SECONDS));
|
@reactive-streams/contributors Merging this tomorrow unless someone requests more time to review. |
|
Great work, @akarnokd! Thank you |
|
Yes, thanks very much @akarnokd ! |
This PR adds a
SubmissionPublisherTCK test to theflow-tcksubproject.I've tested it with both Java 9.0.1 (via Gradle) and the custom patch from Doug Lea's comment (via IntelliJ's own test runner configured).