Skip to content

update tck README #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2017
Merged

update tck README #392

merged 2 commits into from
Nov 16, 2017

Conversation

shenghaiyang
Copy link
Contributor

No description provided.

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch - LGTM

@viktorklang
Copy link
Contributor

Thank you!

@viktorklang
Copy link
Contributor

Hi @shenghaiyang,

Would you mind rebasing on top of current HEAD?

@viktorklang
Copy link
Contributor

(I'm seeing some weird Travis/Gradle issues: https://travis-ci.org/reactive-streams/reactive-streams-jvm/jobs/274536357)

@akarnokd
Copy link
Contributor

akarnokd commented Nov 8, 2017

JDK 6 is no longer supported. The HEAD should contain the correct CI settings.

@viktorklang
Copy link
Contributor

Hi @shenghaiyang, your PR unfortunately needs to be reset.
Could you reset your master branch to origin/master and then cherry-pick commit 37324b6 to it and update the PR?

@viktorklang
Copy link
Contributor

@shenghaiyang Alternatively, you set your master branch to be https://github.com/reactive-streams/reactive-streams-jvm/tree/pr/392 and push that to your repo (which would update the pr)

@shenghaiyang
Copy link
Contributor Author

@viktorklang Thank you very much!

@@ -41,7 +41,7 @@ Since the TCK is aimed at Reactive Stream implementers, looking into the sources
In order to make mapping between test cases and Specification rules easier, each test case covering a specific
Specification rule abides the following naming convention: `TYPE_spec###_DESC` where:

* `TYPE` is one of: [#type-required](required), [#type-optional](optional), [#type-stochastic](stochastic) or [#type-untested](untested) which describe if this test is covering a Rule that MUST or SHOULD be implemented. The specific words are explained in detail below.
* `TYPE` is one of: [required](#type-required), [optional](#type-optional), [stochastic](#type-stochastic) or [untested](#type-untested) which describe if this test is covering a Rule that MUST or SHOULD be implemented. The specific words are explained in detail below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok :-)

@ktoso
Copy link
Contributor

ktoso commented Nov 16, 2017

Thanks, LGTM :)

@viktorklang
Copy link
Contributor

Awesome, thank you @shenghaiyang!

@viktorklang viktorklang merged commit 959676b into reactive-streams:master Nov 16, 2017
@viktorklang viktorklang added this to the 1.0.2 milestone Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants