-
Notifications
You must be signed in to change notification settings - Fork 534
update tck README #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tck README #392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good catch - LGTM
Thank you! |
Hi @shenghaiyang, Would you mind rebasing on top of current HEAD? |
(I'm seeing some weird Travis/Gradle issues: https://travis-ci.org/reactive-streams/reactive-streams-jvm/jobs/274536357) |
JDK 6 is no longer supported. The HEAD should contain the correct CI settings. |
Hi @shenghaiyang, your PR unfortunately needs to be reset. |
@shenghaiyang Alternatively, you set your master branch to be https://github.com/reactive-streams/reactive-streams-jvm/tree/pr/392 and push that to your repo (which would update the pr) |
@viktorklang Thank you very much! |
@@ -41,7 +41,7 @@ Since the TCK is aimed at Reactive Stream implementers, looking into the sources | |||
In order to make mapping between test cases and Specification rules easier, each test case covering a specific | |||
Specification rule abides the following naming convention: `TYPE_spec###_DESC` where: | |||
|
|||
* `TYPE` is one of: [#type-required](required), [#type-optional](optional), [#type-stochastic](stochastic) or [#type-untested](untested) which describe if this test is covering a Rule that MUST or SHOULD be implemented. The specific words are explained in detail below. | |||
* `TYPE` is one of: [required](#type-required), [optional](#type-optional), [stochastic](#type-stochastic) or [untested](#type-untested) which describe if this test is covering a Rule that MUST or SHOULD be implemented. The specific words are explained in detail below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you apply the same fix in https://github.com/reactive-streams/reactive-streams-jvm/blob/master/tck-flow/README.md ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok :-)
Thanks, LGTM :) |
Awesome, thank you @shenghaiyang! |
No description provided.