Skip to content

+tck #362 wait for request signal in 209, and new additional tests #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2017
Merged

+tck #362 wait for request signal in 209, and new additional tests #374

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1836379
+tck #362 wait for request signal in 209, and new additional tests
ktoso May 29, 2017
fcd1533
fix tests by using proxied subscriber,
ktoso Jun 16, 2017
9910b8b
Merge branch 'master' into wip-209-210-improve
viktorklang Jun 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tck/src/main/java/org/reactivestreams/tck/SubscriberBlackboxVerification.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ public void required_spec209_blackbox_mustBePreparedToReceiveAnOnCompleteSignalW
@Override @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void run(BlackboxTestStage stage) throws Throwable {
final Subscriber<? super T> sub = stage.sub();

sub.onComplete();
stage.subProxy().expectCompletion();
}
Expand Down
19 changes: 19 additions & 0 deletions tck/src/main/java/org/reactivestreams/tck/support/SubscriberBlackboxVerificationRules.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,26 @@ public interface SubscriberBlackboxVerificationRules {
* </ul>
*/
void required_spec210_blackbox_mustBePreparedToReceiveAnOnErrorSignalWithPrecedingRequestCall() throws Throwable;

/**
* Asks for a {@code Subscriber}, signals {@code onSubscribe} followed by an {@code onError} synchronously.
* <p>
* <b>Verifies rule:</b> <a href='https://github.com/reactive-streams/reactive-streams-jvm#2.10'>2.10</a>
* <p>
* If this test fails, the following could be checked within the {@code Subscriber} implementation:
* <ul>
* <li>if the {@code Subscriber} throws an unchecked exception from its {@code onSubscribe} or
* {@code onError} methods.
* </ul>
*/
void required_spec210_blackbox_mustBePreparedToReceiveAnOnErrorSignalWithoutPrecedingRequestCall() throws Throwable;

/**
* Currently, this test is skipped because it would require analyzing what the {@code Subscriber} implementation
* does.
* <p>
* <b>Verifies rule:</b> <a href='https://github.com/reactive-streams/reactive-streams-jvm#2.11'>2.11</a>
*/
Copy link
Contributor Author

@ktoso ktoso Jun 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right, forgot to add the new-style-comment; thanks a ton for doing so.
Comments sound good, thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Np! Thanks for all your hard work, @ktoso!

void untested_spec211_blackbox_mustMakeSureThatAllCallsOnItsMethodsHappenBeforeTheProcessingOfTheRespectiveEvents() throws Exception;
/**
* Currently, this test is skipped because the test for
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.