TCK: Request -1 in 309 instead of a random non-positive number #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorklang
reviewed
Apr 4, 2017
| @@ -884,8 +884,7 @@ public void required_spec309_requestNegativeNumberMustSignalIllegalArgumentExcep | |||
| @Override | |||
| public void run(Publisher<T> pub) throws Throwable { | |||
| final ManualSubscriber<T> sub = env.newManualSubscriber(pub); | |||
| final Random r = new Random(); | |||
| sub.request(-r.nextInt(Integer.MAX_VALUE)); | |||
| sub.request(-1); | |||
There was a problem hiding this comment.
I meant "subtract 1 from the random value"
There was a problem hiding this comment.
0 is also invalid tho :)
There was a problem hiding this comment.
0 is explicitly tested with required_spec309_requestZeroMustSignalIllegalArgumentException.
Restored randomness and subtracted 1.
ktoso
approved these changes
Apr 6, 2017
|
if @reactive-streams/contributors agree we can merge |
smaldini
approved these changes
Apr 11, 2017
|
Thanks @akarnokd! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
required_spec309_requestNegativeNumberMustSignalIllegalArgumentExceptiondeterministically request -1 as the negative number.