Fixes #233 by implementing support for triggered demand in in the SubscriberBlackboxVerification #252
Conversation
| * By default this method does nothing. | ||
| */ | ||
| public void triggerRequest(final Subscriber<? super T> subscriber) { | ||
|
|
There was a problem hiding this comment.
"this page method body was intentionally left blank." 😉
|
This looks v. good I think, thanks Viktor! |
|
@ktoso @purplefox & @reactive-streams/contributors Addressed review feedback in the following commit: 658c95e |
|
@reactive-streams/contributors & @purplefox This PR is ready to merge, Tim please verify that this fixes your issue and contributors-please raise any objections you might have (this is completely without impact on already TCK-passing implementations). I'll merge this on the 30th of March unless there are objections. Thanks |
viktorklang
force-pushed
the
wip-233-support-manual-demand-√
branch
from
658c95e to
9f2a05f
Compare
viktorklang
changed the title
|
This works for me. (Aside: One small issue, not specifically related to this PR, I had to install Java 7 to build the TCK as it doesn't build using Java 8 - small JavaDoc issue. Java 7 will be EOL in a month) |
|
Great that it worked. What was the Java Doc issue? Cheers,
|
…scriberBlackboxVerification
viktorklang
force-pushed
the
wip-233-support-manual-demand-√
branch
from
9f2a05f to
c97be99
Compare
|
@purplefox Alright, I found and fixed the issue, it was due to the requirement to qualify nested classes in Javadoc links. |
…demand-√ Fixes #233 by implementing support for triggered demand in in the SubscriberBlackboxVerification
Fixes #233 @purplefox & @ktoso?