Skip to content

Publisher: add space to javadoc #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2015

Conversation

davidmoten
Copy link
Contributor

Doesn't get more trivial than this PR. Publisher javadoc lacked a space.

@ktoso
Copy link
Contributor

ktoso commented Mar 23, 2015

Thanks, LGTM :-)

@viktorklang
Copy link
Contributor

@davidmoten Thanks for the due diligence!

@viktorklang
Copy link
Contributor

@davidmoten Would you mind add yourself to the end of the copyright waivers file?

https://github.com/reactive-streams/reactive-streams-jvm/blob/master/CopyrightWaivers.txt

Not that it is strictly needed for this contribution, but that it feels good to lower the barrier to submit more improvements from you :)

@davidmoten
Copy link
Contributor Author

righto, have done. I'll stay on the lookout for whitespace issues...

@viktorklang
Copy link
Contributor

@davidmoten Your updated waivers file cannot be seen in this PR, did you push?

@davidmoten
Copy link
Contributor Author

ah sorry, I see what happened. Haven't used the automatic fork on edit
stuff from github before. PR is there now.

On 25 March 2015 at 23:09, Viktor Klang (√) [email protected]
wrote:

@davidmoten https://github.com/davidmoten Your updated waivers file
cannot be seen in this PR, did you push?


Reply to this email directly or view it on GitHub
#247 (comment)
.

@viktorklang viktorklang added this to the 1.0.0.RC4 milestone Mar 25, 2015
viktorklang added a commit that referenced this pull request Mar 25, 2015
Publisher: add space to javadoc
@viktorklang viktorklang merged commit 0b59ebe into reactive-streams:master Mar 25, 2015
@viktorklang
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants