+tck #232 explain which tests are mendatory to be "compliant" #245
Conversation
ktoso
force-pushed
the
wip-readme-about-which-tests-to-impl-ktoso
branch
from
3760e19 to
ced02c5
Compare
| @@ -479,6 +479,22 @@ public class SkippingIdentityProcessorTest extends IdentityProcessorVerification | |||
| } | |||
| ``` | |||
|
|
|||
| ## Which verifications must be implemented by an compliant implementation? | |||
There was a problem hiding this comment.
Open for better suggestions for the section title here, ideas?
| @@ -479,6 +479,22 @@ public class SkippingIdentityProcessorTest extends IdentityProcessorVerification | |||
| } | |||
| ``` | |||
|
|
|||
| ## Which verifications must be implemented by an compliant implementation? | |||
| In order to be considered an Reactive Streams compliant we require implementations to cover their | |||
There was a problem hiding this comment.
This sentence is unclear. What does it mean? s/an/a
There was a problem hiding this comment.
I'm trying to answer the question @purplefox had here, paraphrasing it: "which tests do I need to implement / pass for my framework to be OK to say we're a reactive streams impl?" Since we have a TCK, I hoped to clarify which tests we want people to implement and pass here.
Do you think the "compliant" word is confusing or a good one here?
There was a problem hiding this comment.
Can it be made even simpler? Something like: In order to be a Reactive Streams implementation, aside from following the specification, one must also make sure that the implementations of the Publisher and Subscriber pass the TCK?
ktoso
force-pushed
the
wip-readme-about-which-tests-to-impl-ktoso
branch
from
ced02c5 to
07ea4a1
Compare
| @@ -479,6 +487,22 @@ public class SkippingIdentityProcessorTest extends IdentityProcessorVerification | |||
| } | |||
| ``` | |||
|
|
|||
| ## Which verifications must be implemented by a compliant implementation? | |||
| In order to be considered an Reactive Streams compliant require implementations to cover their | |||
There was a problem hiding this comment.
This sentence does not make sense to me, is there some word missing?
There was a problem hiding this comment.
It was missing word (reactive streams compliant implementation), but that leads to repetition.
So I'll go with In order to be considered Reactive Streams compliant, implementations must cover their...
|
👍 from me after addressing the last comment. |
|
@reactive-streams/contributors Given that this only clarifies the TCK documentation and has already been available for review for 4 days, I'm going to merge this within 24h unless someone yells "no!". Thanks. |
|
@reactive-streams/contributors Merging without objection |
|
@ktoso this needs a rebase before it can merge cleanly. Would you mind? |
ktoso
force-pushed
the
wip-readme-about-which-tests-to-impl-ktoso
branch
from
07ea4a1 to
d503210
Compare
|
@viktorklang rebased and pushed |
|
Thanks @ktoso, I'll merge once Travis approves |
…pl-ktoso +tck #232 explain which tests are mendatory to be "compliant"
Resolves #232