+TCK verifyNoAsyncErrors now by default waits, fixes spec111 #240
Conversation
| * Waits for {@link TestEnvironment#defaultTimeoutMillis()} and then verifies that no asynchronous errors | ||
| * were signalled pior to, or during that time (by calling {@code flop()}). | ||
| */ | ||
| public void verifyNoAsyncErrors() { |
There was a problem hiding this comment.
this ought to call verifyNoAsyncErrors(defaultTimeoutMillis())
|
@ktoso Reviewed. What's the status? |
ktoso
force-pushed
the
async-errors-with-timeout
branch
from
9453fd3 to
4df0d4d
Compare
ktoso
changed the title
|
@ktoso is this still WIP, and if so, when will it not be WIP anymore? |
|
The WIP part still exists, but it is (possibly) additive, not other in-another-way changing (maybe one or two more tests needs have delay but don't). Since that test we identified as troublesome let's fix it. I propose to merge as is and if I find another instance of such problem it's a good stand-along PR. |
|
@ktoso I won't merge something that is WIP so split the WIP part out into another Issue/PR. Thanks! |
ktoso
changed the title
|
The WIP part is "look at more tests with intense passion", no actual code in the PR. |
|
@ktoso Thanks, Konrad, I appreciate it! |
ktoso
force-pushed
the
async-errors-with-timeout
branch
2 times, most recently
from
d7a2e1d to
2512dc4
Compare
|
Rebased, re-read the diff and checked against akka that it fixes the discovered problem. |
ktoso
force-pushed
the
async-errors-with-timeout
branch
from
2512dc4 to
0b055a5
Compare
|
Also included the link fix we mentioned during review ( Resolves #249 |
|
👍 great work Konrad, thank you! @reactive-streams/contributors Merging. |
+TCK verifyNoAsyncErrors now by default waits, fixes spec111
Resolves #239
Don't merge yet, I want to look though all other specs but lacked the capacity to have done this today.
Question that needs feedback here is if we want to rename the existing method to be less confusing - I say yes.