Removes the RECOMMENDED section from 1.10 #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reactive-streams/contributors As discussed in #178 this change doesn't semantically change the spec, since the only thing it does is to remove a RECOMMENDED section which is already implied by the affected rule and the rules 1.10, 1.12, 2.5 and 2.12. Given that it doesn't change the semantics of the spec, and there has been ample time to comment on the Issue, is everyone OK with merging this ASAP so we can ship 1.0.0.RC1 before the end of the year? |
The reason is that it is not meaningful, as the same Subscriber could be subscribed to several *different* Publishers at the same time. The spec already requires that a Subscriber is only subscribed to one Publisher, and only once. And the spec also is clear that the only legal way to reject a Subscription in a Publisher is by issuing an `onError` signal to it.
viktorklang
force-pushed
the
wip-178-remove-1.10-recommended-√
branch
from
de65e0d to
ed86987
Compare
|
Happy holidays everyone! :-) Since nobody objected or needed more time to think, I'm merging this in. (keep in mind that it does not change the semantics of the spec!) |
viktorklang
added a commit
that referenced
this pull request
Dec 24, 2014
…ommended-√ Removes the RECOMMENDED section from 1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason is that it is not meaningful, as the same Subscriber
could be subscribed to several different Publishers at the same time.
The spec already requires that a Subscriber is only subscribed to one Publisher,
and only once. And the spec also is clear that the only legal way to reject a
Subscription in a Publisher is by issuing an
onErrorsignal to it.Fixes #178