+tck carry the original exception to fail(), helps tracking exceptions #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -167,7 +167,7 @@ public void verifyNoAsyncErrors() { | |||
| if (e instanceof AssertionError) { | |||
| throw (AssertionError) e; | |||
| } else { | |||
| fail("Async error during test execution: " + e); | |||
| fail("Async error during test execution: " + e, e); | |||
There was a problem hiding this comment.
Be explicit about e.getMessage here? (and perhaps enclose it in double-quotes)
There was a problem hiding this comment.
good idea, fixing. I think the + e looked too much like an , e when re reading this hundred times, and I missed that it's swallowing the trace.
|
@reactive-streams/contributors Usability-improvement to the TCK, please object before the 28th of November (this does not change the spec or any of the APIs in any way) |
ktoso
force-pushed
the
impr-tck-stacktraces
branch
from
47b97c4 to
aeeb961
Compare
|
Updated |
viktorklang
added a commit
that referenced
this pull request
Nov 28, 2014
+tck carry the original exception to fail(), helps tracking exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the TCKs usability by carrying around the "original exception" to TestNG's
fail().Previously implementors would only get the message of their exception and would have to track down where exactly it came from manually in these cases. Now the original exception is seen as cause of the assertion error thrown by testng.
Would be great to include this in the RC1.