Fail test in case of double onError/onComplete signals #122
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
impr-fail-tck-when-onError-twice-ktoso
branch
from
deb5a31 to
6aac3f9
Compare
|
It's not a belief, it's mandatory :) "7 Once a terminal state has been signaled (onError, onComplete) it is REQUIRED that no further signals occur. Situational scenario MAY apply [see 2.13]" As for 2.13, see: https://github.com/reactive-streams/reactive-streams/pull/117/files |
|
LGTM, thanks |
|
👍 |
|
@reactive-streams/contributors Ample time has been given to comment, please give a 👍 or object to this change before the 24th of October GMT+0. If no one objects before that then this will be merged. |
|
@reactive-streams/contributors Merging without objections. |
viktorklang
added a commit
that referenced
this pull request
Oct 24, 2014
…toso Fail test in case of double onError/onComplete signals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating some Akka streams tests @patriknw discovered we accidentally called onError twice on the overflow protection. We believe
onErrorshould be a "final" call, according to https://github.com/reactive-streams/reactive-streams#1.7 (the situational rules mentioned in this rule don't apply here IMO).This addition should help to notice such implementation mistakes sooner. Please review @reactive-streams/contributors (I somehow can't get this to be a "ping" hm...).
This PR changes:
spec317_mustSignalOnErrorWhenPendingAboveLongMaxValueto check that no other errors than the one expected error were signalledonErrorandonCompletecalls on the same subscriber. The situational rule linked from1.7still holds as it states "onErrorifonCompletefailed", which is still allowed with this update of course (we only disallow multipleonError / onCompletecalls)