Rule 3.12 verification in subscriber whitebox now really checks it #121
Conversation
| } catch (Throwable th) { | ||
| stillBeingSignalled = true; | ||
| } | ||
| } while (stillBeingSignalled); |
There was a problem hiding this comment.
no potentially infinite loops please ;)
There was a problem hiding this comment.
Right, had a counter here actually but removed it (jet-lag might be showing...), thanks :-)
I'll add it back (as method, so it's configurable, in case impl. does "batches of 1000" etc).
|
Apart from small stuff LGTM on my side |
ktoso
force-pushed
the
wip-rule312-for-reals-ktoso
branch
from
6a0bf30 to
9284dee
Compare
|
Just noticed that this is probably not enough (falsely green), will update this PR soon. |
ktoso
force-pushed
the
wip-rule312-for-reals-ktoso
branch
2 times, most recently
from
be98041 to
741503e
Compare
|
Now I'm happy with this test.
I've used it and looked at it for a while and seems good, please review guys. |
This verification is now moved to PublisherVerification, as it's a publishers behavior (*it* must stop emiting, not the subscriber). Resolves reactive-streams#115
ktoso
force-pushed
the
wip-rule312-for-reals-ktoso
branch
from
741503e to
79e1669
Compare
| onNextsSignalled += 1; | ||
| stillBeingSignalled = true; | ||
| } | ||
| } while (stillBeingSignalled && onNextsSignalled < totalDemand); |
|
LGTM! 👍 Great work, @ktoso |
|
👍 |
|
@reactive-streams/contributors Ample time has been given to comment, please give a 👍 or object to this change before the 24th of October GMT+0. If no one objects before that then this will be merged. |
|
@reactive-streams/contributors Merging |
Rule 3.12 verification in subscriber whitebox now really checks it
This PR reimplements the whitebox
spec312_cancelMustRequestThePublisherToEventuallyStopSignaling, as @danarmak correctly noticed the previous implementation was not testing what it claimed it did.Please review @danarmak, @viktorklang and @reactive-streams/contributors.
I may be a bit jet-lagged, please verify if this makes sense... :-)
Resolves #115