Skip to content

allow contravariant use of Subscriber #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ onError | (onSubscribe onNext* (onError | onComplete)?)

```java
public interface Publisher<T> {
public void subscribe(Subscriber<T> s);
public void subscribe(Subscriber<? super T> s);
}
````

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
public class StockPricePublisher implements Publisher<Stock> {

@Override
public void subscribe(final Subscriber<Stock> s) {
public void subscribe(final Subscriber<? super Stock> s) {
s.onSubscribe(new Subscription() {

AtomicLong capacity = new AtomicLong();
Expand Down Expand Up @@ -46,10 +46,10 @@ public void startConsuming() {
}

private static final class EventHandler implements Handler {
private final Subscriber<Stock> s;
private final Subscriber<? super Stock> s;
private final AtomicLong capacity;

private EventHandler(Subscriber<Stock> s, AtomicLong capacity) {
private EventHandler(Subscriber<? super Stock> s, AtomicLong capacity) {
this.s = s;
this.capacity = capacity;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.reactivestreams.example.unicast;

import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicLong;

import org.reactivestreams.Subscription;
import org.reactivestreams.Subscriber;
Expand All @@ -9,13 +10,13 @@
class InfiniteIncrementNumberPublisher implements Publisher<Integer> {

@Override
public void subscribe(final Subscriber<Integer> s) {
public void subscribe(final Subscriber<? super Integer> s) {

final AtomicInteger i = new AtomicInteger();

Subscription subscription = new Subscription() {

AtomicInteger capacity = new AtomicInteger();
AtomicLong capacity = new AtomicLong();

@Override
public void request(long n) {
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/reactivestreams/Publisher.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ public interface Publisher<T> {
*
* @param s the {@link Subscriber} that will consume signals from this {@link Publisher}
*/
public void subscribe(Subscriber<T> s);
public void subscribe(Subscriber<? super T> s);
}