clarify meaning of “overflow protection”

[rkuhn]

@benjchristensen proposed

• A Subscription MUST support an infinite number of calls to request and MUST support a pending request count up to 2^63-1 (java.lang.Long.MAX_VALUE). If more than 2^63-1 are requested in pending then Subscription MUST emit an error to Subscriber.onError.

[viktorklang]

Yes, I cannot see how it could be handled differently, it cannot be silently ignored since the Subscriber is keeping track of the demand it has requested. It is also fail-fast which is good.

I'd like to propose:

• A Subscription MUST support an infinite number of calls to request and MUST support a pending request count up to 2^63-1 (java.lang.Long.MAX_VALUE). If more than 2^63-1 are requested in pending then it MUST signal an onError with java.lang.IllegalStateException on the given Subscriber. The cause message MUST include a reference to this rule and/or quote the full rule

[viktorklang]

Others? @reactive-streams/contributors

[smaldini]

Not sure, what about maxing out the capacity to Long.MAX instead of throwing an exception ?

[viktorklang]

I thought about that but I don't think it'll work because then the
Publisher and the Subscriber does not agree on the outstanding
demand—there's a divergence and it is unclear what it'd mean in practice.
I think we have to fail fast.

On Sun, Jun 29, 2014 at 12:32 AM, Stephane Maldini <[email protected]

wrote:

Not sure, what about maxing out the capacity to Long.MAX instead of
throwing an exception ?

—
Reply to this email directly or view it on GitHub
#66 (comment)
.

Cheers,
√

[mariusae]

I would omit "infinite number of calls" -- anything involving infinities is bound to become ontological at some point :-) Maybe say: "indefinite number of calls"

[viktorklang]

@mariusaeriksen How about "unbounded"?

[mariusae]

I like that.

On Jun 30, 2014, at 2:39, Viktor Klang (√) [email protected] wrote:

@mariusaeriksen How about "unbounded"?

—
Reply to this email directly or view it on GitHub.

[viktorklang]

Time to finalize the votes, if you need more time, please respond here with how much time (reasonable) is needed to cast your vote. @reactive-streams/contributors

[tmontgomery]

👍 Unbounded added to @viktorklang wording makes sense

[smaldini]

Happy to merge this.

[benjchristensen]

👍 for the modified text with "unbounded":

A Subscription MUST support an unbounded number of calls to request and MUST support a pending request count up to 2^63-1 (java.lang.Long.MAX_VALUE). If more than 2^63-1 are requested in pending then it MUST signal an onError with java.lang.IllegalStateException on the given Subscriber. The cause message MUST include a reference to this rule and/or quote the full rule.