-
Notifications
You must be signed in to change notification settings - Fork 534
Release version 0.4.0 #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1. Obviously :). I am regretting the loss of Processor but we can leave without it for now. Not sure why that one has been ditched tho. Sent from my iPhone
|
Why does |
I'm okay with releasing 0.4 with the current code and spec. |
It's just that it is very convenient for combining libraries together or modularising streams, nothing about forcing a given transformation. If a library provide an arbitrary operation, I'd just like to be able to lift a current publisher with it and still retrieve it's output, like a logical RequestReply pattern (in fact it would look like this way in tcp application of the spec). Sent from my iPhone
|
Migrated this to #22 (comment) since |
Cheers, I weighed in this as it is quite simple to be re-introduced and since we will live on 0.4 for at least another couple month (until we get TCK updated which won't break this dependency). Can we give it a chance to be discussed in #22 for a couple days and poll a quick vote on it before validating 0.4 ? I'd prefer to be rather inclusive at first than exclusive. |
I agree that we should soon release an updated version with the source-code changes. Jon already mentioned the TCK and this is an important point: we currently rely upon the 0.3 TCK for our Akka Streams test suite, as do others, so we must codify our current specification in order to be able to go forward. This is a bit of a catch 22: we need the interfaces to develop the TCK and the TCK is needed for releasing the full package. We can break this cycle in two ways: develop the TCK based on locally published builds of the master branch, or release a 0.4.0-M1 without the TCK. I would prefer the latter, then we get stable builds for creating at least three compliant implementations so that we can discuss the emerging TCK meaningfully (i.e. backed by real code). |
Processor is in now. I assume we need to go over the spec and make sure it's in good shape and then have a stab at the TCK. Who does what? |
Bare from editing Readme.md (which I am doing now), by stabbing the TCK you mean remove it or quickly adapt it ? |
@smaldini We also need the spec updated. |
BTW in https://github.com/reactive-streams/reactive-streams/tree/edit-doc-simplified-types I was thinking about reactive-streams-spi name, should that change to just reactive-streams since we have simplified types now ? And version is set to 0.4.M1 as proposed here but I am not sure about this. |
We can reintroduce the removed spec files and amend them. WDYT? |
Small thing, but if we're following "correct" semantic versioning, there should be three decimal version numbers and an alphanumeric identifier. e.g. |
Yes, we need to revive the spec and make sure it reflects the decisions made since it was written. |
So the https://github.com/reactive-streams/reactive-streams/blob/edit-doc-simplified-types/tck/src/main/resources/spec.md is online again. But now we need a cross review to amend the doc. Starting from the simplest, Processor pretty much not changed (still obeys both P/S rules, and still propagating cancel upstreams,complete downstream). |
Changes in #61 |
note that specs.md and README.md could be merged. /cc @viktorklang @benjchristensen |
0.4.0.M1 is on MC. Not yet closing this issue as we discuss the last comments. @viktorklang sent a reminder on any of them :) |
So what's left to be done for 0.4.0, now that M1 is released? |
@alexandru Going through the open Issues and settling them as well as porting the TCK to the new spec. |
Waiting for Maven Central to sync on 0.4.0 |
Awesome, thanks @smaldini! |
@smaldini it seems like you didn't push the tag to the repo, could you do On Fri, Sep 19, 2014 at 6:17 PM, Stephane Maldini [email protected]
Cheers, |
@smaldini nm, I'll push the tag. On Sat, Sep 27, 2014 at 5:32 PM, √iktor Ҡlang [email protected]
Cheers, |
Oh my bad I was waiting for the maven artifacts to be published and I probably felt asleep! Thanks Viktor! Sent from my iPhone
|
No worries On Sat, Sep 27, 2014 at 10:39 PM, Stephane Maldini <[email protected]
Cheers, |
I swear I will after a couple mojitos! Cheers mate for the PR and again On Saturday, September 27, 2014, Viktor Klang (√) [email protected]
Stéphane |
We're currently blocked waiting on the issues being discussed around "heaviness" (#54) and the onComplete/onError API contract to be settled before we can move forward with our Reactive Streams implementation which is currently dependent on version 0.3.0 artifacts.
Are we in a position yet where we can consolidate the changes we discussed into a new 0.4.0 artifact so we can move forward with our implementation? We have other projects that will need to use our Reactive Streams implementation and they are essentially waiting on the outcome of these discussions. The longer this drags out in discussions the behinder we get. :)
We seem to be in general agreement on the vast majority of items, with some differences of opinion in some of the finer points. But I don't see anything holding us up from moving forward with a TCK or whatever we plan to release for 0.4.0.
Thoughts?
The text was updated successfully, but these errors were encountered: